Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

format_units return was truncating the decimal places #675

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

x3ccd4828
Copy link
Contributor

@x3ccd4828 x3ccd4828 commented Dec 11, 2021

Motivation

The recent change to format_units was truncating the leading zeros of the decimal places causing the following output as an example: 1001234567891234567 eth became 1.1234567891234567 when formatted.

Solution

Added zero padding to the decimal numbers when printed.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gakonst gakonst merged commit 0e133e4 into gakonst:master Dec 11, 2021
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
…rking tree changes (gakonst#675)

Removed the "git checkout -- ." command.  This had the effect of clearing all uncommitted changes in tracked files from the working tree.

Fixes issue gakonst#673

Co-authored-by: Drake Evans <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants