Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(solc): add source map parser #658

Merged
merged 9 commits into from
Jan 6, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 8, 2021

Motivation

Closes #639

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse mattsse force-pushed the matt/add-source-map-parser branch from 0262932 to a75dee4 Compare December 8, 2021 00:27
@gakonst
Copy link
Owner

gakonst commented Jan 1, 2022

Sourcemap parsing algorithm shared by @MrChico here.

@brockelmore has been using this branch to build out the debugger and it seems to be working correctly so far.

Should we perhaps merge, or have any bugs been detected?

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 6, 2022

added test mode that does a roundtrip check for the parsed input/elements, very confident that's correct now @gakonst, same algo as https://gist.github.com/MrChico/fffdf5526b21a99e84f48533f159b540

can be merged imo, @brockelmore?

@brockelmore
Copy link
Collaborator

based on my testing this is good to go

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed for idiomatic rust / missing docs and to see if I can follow the code, LGTM. have not reviewed the full algorithm so defer to you guys / your manual testing here.

we'll close the feedback loop with the debugger and coverage features on forge, so any bugs can be uncovered there.

@gakonst gakonst merged commit 88b3422 into gakonst:master Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solidity source map parser
3 participants