-
Notifications
You must be signed in to change notification settings - Fork 795
Conversation
0262932
to
a75dee4
Compare
Sourcemap parsing algorithm shared by @MrChico here. @brockelmore has been using this branch to build out the debugger and it seems to be working correctly so far. Should we perhaps merge, or have any bugs been detected? |
added test mode that does a roundtrip check for the parsed input/elements, very confident that's correct now @gakonst, same algo as https://gist.github.com/MrChico/fffdf5526b21a99e84f48533f159b540 can be merged imo, @brockelmore? |
based on my testing this is good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed for idiomatic rust / missing docs and to see if I can follow the code, LGTM. have not reviewed the full algorithm so defer to you guys / your manual testing here.
we'll close the feedback loop with the debugger and coverage features on forge, so any bugs can be uncovered there.
Motivation
Closes #639
Solution
PR Checklist