Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Fix nonce too low for different providers #655

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Fix nonce too low for different providers #655

merged 1 commit into from
Dec 6, 2021

Conversation

kekonen
Copy link
Contributor

@kekonen kekonen commented Dec 6, 2021

This is a complimentary PR to the previous one #643
This one solves the same issue but for different providers.
The implemented test is based on: https://github.com/smartcontractkit/chainlink/blob/develop/core/services/eth/errors_test.go#L24-L50

mattsse
mattsse approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gakonst
gakonst approved these changes Dec 6, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I think should probably move to tighter provider errors instead of manually parsing the string everywhere, but this lgtm

@gakonst gakonst merged commit fffb965 into gakonst:master Dec 6, 2021
@kekonen kekonen deleted the daniil/nonce_too_low_different branch December 7, 2021 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kekonen @gakonst @mattsse