This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(provider::ws): ignore the websocket response when the request has been cancelled #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
force pushed to fix a fmt issue, didn't notice that it was using a nightly fmt. I guess IPC transportation might have similar issue, but I've never tried or tested it, so I'll just leave it to someone else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases when the request is out, but cancelled locally before it gets back, then later on, the replied request should be ignored, otherwise, it hits an error and aborts the whole websocket connection.