This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: remove generic const from TimeLag #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketchang
changed the title
prestwich
approved these changes
Nov 16, 2021
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* Add bug report form * Add labels for bugs * Add feature request form * Link to support Telegram * Ask for command in bug form * Ask for Solidity snippets in bug form * Add PR template * Badges nit * Add contributing guidelines * Refer to Foundry book Also cleans up some other parts of the README * Add forge version field to bug form * Replace EVM abstraction with Foundry GHA * Fix typos in contributing guidelines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TimeLag middleware parametrizes the lag amount (number of blocks to lag behind) as generic constant. This prevents devs from being able to instantiate the TimeLag's lag amount with a runtime variable.
Solution
Replaces the generic const with regular struct field.