This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(solc): do not unnecessarily query for solc version #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter is not used in any useful way currently, and it prevents us from using clean installations of SVM which do not have an instantiated /Users/gakonst/.svm directory
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* lib linking * fmt * `run` lib linking support * clippy + fmt * nonce fix * cargotoml fix * remove dirty deploy WIP * refactor link step * Update cli/src/cmd/run.rs Co-authored-by: Matthias Seitz <[email protected]> * Update forge/src/multi_runner.rs Co-authored-by: Matthias Seitz <[email protected]> * Update cli/src/cmd/run.rs Co-authored-by: Matthias Seitz <[email protected]> * nits * refactor post_link * Update cli/src/cmd/run.rs Co-authored-by: Georgios Konstantopoulos <[email protected]> * Update forge/testdata/LibLinking.sol Co-authored-by: Georgios Konstantopoulos <[email protected]> * Update cli/src/cmd/run.rs Co-authored-by: Georgios Konstantopoulos <[email protected]> * Update forge/src/multi_runner.rs Co-authored-by: Georgios Konstantopoulos <[email protected]> * nits * test fixes * remove next_nonce * lints Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter is not used in any useful way currently, and it prevents us from using clean installations of SVM
which do not have an instantiated /Users/gakonst/.svm directory