Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

bump ethereum-types' impl-serde to 0.3.2 #569

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

shekhirin
Copy link
Contributor

Motivation

@frjnn reported an issue:

I'm working on geth traces, I'm facing the following problem: what should I do to deserialize a big int from the raw trace if it fails with "0x prefix is missing"?

Example from geth's debug_traceTransaction (values under the storage key):

> debug.traceTransaction("0x2059dd53ecac9827faad14d364f9e04b1d5fe5b506e3acc886eff7a6f88a696a")
{
  gas: 85301,
  returnValue: "",
  structLogs: [{
      depth: 1,
      error: "",
      gas: 100000,
      gasCost: 0,
      memory: ["0000000000000000000000000000000000000000000000000000000000000006", "0000000000000000000000000000000000000000000000000000000000000000", "0000000000000000000000000000000000000000000000000000000000000060"],
      op: "STOP",
      pc: 120,
      stack: ["00000000000000000000000000000000000000000000000000000000d67cbec9"],
      storage: {
        0000000000000000000000000000000000000000000000000000000000000004: "8241fa522772837f0d05511f20caa6da1d5a3209000000000000000400000001",
        0000000000000000000000000000000000000000000000000000000000000006: "0000000000000000000000000000000000000000000000000000000000000001",
        f652222313e28459528d920b65115c16c04f3efc82aaedc97be59f3f377c0d3f: "00000000000000000000000002e816afc1b5c0f39852131959d946eb3b07b5ad"
      }
  }]

It's due to ethereum-types dep not supporting serde deserialization of hex strings not prefixed with 0x.

Solution

paritytech/parity-common#598

PR Checklist

  • Bump impl-serde with cargo update -p impl-serde

@shekhirin shekhirin changed the title bump etherum-types' impl-serde to 0.3.2 bump etherum-types' impl-serde to 0.3.2 Nov 10, 2021
@frjnn
Copy link
Contributor

frjnn commented Nov 10, 2021

Wonderful

@shekhirin shekhirin changed the title bump etherum-types' impl-serde to 0.3.2 bump ethereum-types' impl-serde to 0.3.2 Nov 10, 2021
@gakonst gakonst merged commit 16c5d33 into gakonst:master Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants