This repository was archived by the owner on Oct 19, 2024. It is now read-only.
feat: use ethers_solc::Solc instead of ethers_core::utils::Solc #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
force-pushed
the
feat/replace-core-solc
branch
from
db052f5 to
d7e14af
Compare
mattsse
reviewed
Oct 30, 2021
Comment on lines
+34
to
+37
| let compiled = match compiled { | ||
| ProjectCompileOutput::Compiled((output, _)) => output, | ||
| _ => panic!("expected compilation artifacts"), | ||
| }; |
There was a problem hiding this comment.
I feel like we should think about either:
- adding an error type in ethers-solc that treats a CompilerOutput of Project::compile as a hard error as
Err(CompilerOutput), this will be more convenient for build scripts and gets rid of theprintln!("{}", output);to print diagnostics - add a
CompilerOutput::into_resultfunction
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* docs: document test-matchers with examples and patterns * docs: fix typos * Update cli/README.md Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get rid of ethers_core::utils::Solc (and the concurrent ganache/geth) setup methods associated with it) and replace it with the more powerful ethers-solc::Solc and ethers-solc::Project.
As drive by changes, we also deserialise the String bytecode as Bytes and the serde_json::Value as Abi.