Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(providers): unify get_block_receipts for eth/parity RPCs #541

Merged
merged 7 commits into from
Oct 30, 2021

Conversation

shekhirin
Copy link
Contributor

Motivation

Resolve #367

Solution

Unify get_block_receipts for erigon/parity nodes into one method

PR Checklist

  • Introduce NodeClient enum w/ TryFrom implementation for parsing from web3_clientVersion
  • Store provider's node client type under mutex on first Provider::node_client() call
  • Decide which RPC to use for get_block_receipts depending on node client type

@shekhirin shekhirin changed the title feat(providers): unify get_block_receipts for eth/parity RPCs refactor(providers): unify get_block_receipts for eth/parity RPCs Oct 29, 2021
@shekhirin shekhirin changed the title refactor(providers): unify get_block_receipts for eth/parity RPCs feat(providers): unify get_block_receipts for eth/parity RPCs Oct 29, 2021
@shekhirin shekhirin force-pushed the feat/get-block-receipts-node-client branch from 482c181 to faec9aa Compare October 29, 2021 18:40
@shekhirin shekhirin force-pushed the feat/get-block-receipts-node-client branch from 1b8d114 to d85f36d Compare October 29, 2021 18:45
@shekhirin shekhirin marked this pull request as ready for review October 29, 2021 19:15
@gakonst gakonst merged commit dc3ac42 into gakonst:master Oct 30, 2021
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
* feat: add more init options

* feat: add no git mode

* rustmft

* feat: check if dir is non empty

* feat: add no-deps alias

* fix: generate file before git

* fix failing tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify fetching of block receipts
2 participants