This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
refactor(core, contract, etherscan): move Chain enum, use HashMap::from #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
changed the title
mattsse
reviewed
Oct 21, 2021
ethers-contract/src/multicall/mod.rs
Outdated
| [ | ||
| // mainnet | ||
| ( | ||
| 1.into(), |
There was a problem hiding this comment.
I feel like there should be function for that?
we already have the Chain enum in the etherscan crate, should we move this to core and add a function for that instead?
There was a problem hiding this comment.
I am OK with doing that, can move the Chain enum to ethers-core probably?
shekhirin
changed the title
shekhirin
changed the title
shekhirin
force-pushed
the
refactor/hashmap-from
branch
from
addf907 to
b23d00e
Compare
shekhirin
force-pushed
the
refactor/hashmap-from
branch
from
b23d00e to
c2c203e
Compare
|
Great stuff |
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* fix gas usage reporting * fix adjustment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #511
Solution
HashMap::from