This repository was archived by the owner on Oct 19, 2024. It is now read-only.
test: fix duplicate tx flakes by rotating through a list of wallets #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
commented
Sep 14, 2021
| let tx = TransactionRequest::new() | ||
| .nonce(nonce) | ||
| .to(addr) | ||
| // 0.1 eth per wallet |
There was a problem hiding this comment.
Suggested change
| // 0.1 eth per wallet | |
| // 1 eth per wallet |
without fetch_add, it's possible that 2 loads happen for the same id before the `store` mutex is acquired'
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* Added workaround for LogNamedDecimalIntFilter not handling negative ints * Added test for LogNamedDecimalIntFilter with negative values * Reverted changes that caused a regression in dec uint log formatting * Fixed log formatting for LogNamedDecimalUintFilter and LogNamedDecimalIntFilter and added additional tests * Removed redundant conversion * Use Signs existing Display impl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this the day our tests stop being flaky? Maybe? We now rotate over private keys associated with a mnemonic, instead of having a bunch of keys lying around and hoping we don't duplicate them somewhere & introduce race conditions.
I've pre-funded the wallets generated as documented here