This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add usage examples for hashing utilities #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolflo
commented
Sep 8, 2021
| /// | ||
| /// Calculate the address of a UniswapV3 pool. | ||
| /// | ||
| /// ``` |
There was a problem hiding this comment.
Does this need a no_run?
gakonst
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
This looks great. Thank you. Maybe custom writing an EIP-712 package might not be as hard as I thought, will take a stab at it (or if you think it'd be easy to abstract this logic into a nice generic-ish package that also works. Maybe with a trait and the user defining a struct implementing the trait for encoding the struct?)
| /// | ||
| /// Calculate the address of a UniswapV3 pool. | ||
| /// | ||
| /// ``` |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils::get_create2_address()that calculates a UniswapV3 pool address.abi.encode()andabi.encodePacked()using ethers-rs.Partially addresses #432.
PR Checklist