This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Linter check fails because rustfmt adds a trailing comma to one of the tests which causes the test to fail. |
mattsse
suggested changes
Sep 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions and nits.
Tes cases look good!
Also since the self.event_aliases.get
is used quite often, consider creating a function for it, fn get_event_alias
or something
mattsse
approved these changes
Sep 2, 2021
Co-authored-by: Matthias Seitz <[email protected]>
mattsse
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Smart contracts written in Solidity can include methods and events with the same name, so long as their signatures are different.
The
contract
crate provides utilities for generating bindings to a contract's ABI. Because Rust does not support function overloading, these utilities enable the user to addmethod_alias
es, which changes the function's name in the generated contract bindings.The crate did not provide aliasing capabilities for event definitions.
Solution
The associated function
add_event_alias
was added to theAbigen
struct withinethers-contract::ethers-contract-abigen
.PR Checklist