This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feature: initial delay in PendingTransaction #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
nvm am dumb, was misreading seconds as milliseconds lmao |
gakonst
approved these changes
Jul 13, 2021
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* update README with console.log details I found this useful, and figured it might be useful for others, so I gave it a quick writeup * Apply suggestions from code review Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#327 introduced a bug. When the tx has just been broadcast, it may not be available over the
eth_getTransactionByHashrpc call. This results in thePendingTransactionexiting immediately with an incorrectdroppedmessageSolution
I added an initial 5 second delay to the
PendingTransactionloop. I don't like this solution, but it is hard to see a better one 🤔