This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: add support for EIP-234 and EIP-1898 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #230
Motivation
These two EIPs are closely related, and allow for querying the blockchain's state at a specified block hash. Which is quite useful when dealing chain reorgs and allows for more robust clients.
Solution
For EIP-234, add method
at_block_hashforEventandFilter.For EIP-1898, modify
Middlewarefunctions affected by the EIP (that is, most that receive aBlockNumber), changing their signatures to receive aBlockIdinstead. Also, change the methodContractCall::blockto receive aBlockId, instead of aBlockNumber.