Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Implement the EthEvent trait for generated event code in abigen #228

Closed
gakonst opened this issue Mar 15, 2021 · 1 comment
Closed

Implement the EthEvent trait for generated event code in abigen #228

gakonst opened this issue Mar 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@gakonst
Copy link
Owner

gakonst commented Mar 15, 2021 •
edited
Loading

In #227, @mattsse introduced the EthEvent trait, for implementing event bindings.

Currently, we only codegen the method implementations without the trait. We should make it so that the codegen also generates the trait.
@gakonst gakonst added the enhancement New feature or request label Mar 15, 2021
@mattsse mattsse mentioned this issue Mar 16, 2021
Merged
@gakonst
Copy link
Owner Author

gakonst commented Mar 17, 2021

Closed in #232

@gakonst gakonst closed this as completed Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gakonst