Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

refactor(abigen): solidity types expansion #2131

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Feb 9, 2023

Motivation

This PR aims to move all Solidity -> Rust type expansion into the types module to remove repetition and improve the logic

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! tysm

I think this will conflict with this 1-line bug fix #2130

@DaniPopes
Copy link
Collaborator Author

I think this will conflict with this 1-line bug fix

Fixed with 2cbd07f

@gakonst gakonst merged commit f9ced12 into gakonst:master Feb 14, 2023
@DaniPopes DaniPopes deleted the refactor/abigen-types branch February 14, 2023 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants