This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
nonce_manager: remove current nonce load when initialized #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If nonce was just initialized, no need for store and load. Just return the stored value without load. Signed-off-by: Gyuho Lee <[email protected]>
mattsse
approved these changes
Jan 5, 2023
|
thanks! helpful. @gyuho the nonce manager has been a bit reliably flaky lately in CI...do you mind taking a closer look? would be really helpful to make this work reliably. |
Sure, let me see if I can help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If nonce was just initialized, no need for store and load.
Solution
Just return the stored value without load.
PR Checklist