-
Notifications
You must be signed in to change notification settings - Fork 794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tysm!
It looks like this includes a lot of valuable but separate contributions, including some breaking changes I think.
I'd rather merge this in separate PRs, so it would be easier to merge this step by step.
Could you please split this as you see fit?
What do you mean by easier to merge? I think a lot of these changes will overlap with each other which would have the opposite effect - I don't think there's much point in splitting this, it's mostly just making the individual oracles and file structure consistent + fixing a few bugs and adding a few tests I finished listing all changes and breaking changes |
this is good to know. I just wanted to check this, before looking at it more closely because it looks like it has a lot of valuable fixes. |
use crate::gas_oracle::{GasCategory, GasOracle, GasOracleError, GWEI_TO_WEI}; | ||
|
||
const ETHERCHAIN_URL: &str = "https://www.etherchain.org/api/gasPriceOracle"; | ||
const URL: &str = "https://www.etherchain.org/api/gasPriceOracle"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://twitter.com/milancermak/status/1604441584808103936 maybe we can use this https://etherchain.org/api/gasnow, which redirects to https://beaconcha.in/api/v1/execution/gasnow
Motivation
Old / non functioning API URLs
Solution
Default
impls and other derivesmod tests
minor breaking changes:
request
toquery
for consistencyquery
methods to return just the Response struct and move parsing in other functionsPR Checklist