Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Cyclic deps #1713

Closed
DaniPopes opened this issue Sep 18, 2022 · 1 comment · Fixed by #1714
Closed

Cyclic deps #1713

DaniPopes opened this issue Sep 18, 2022 · 1 comment · Fixed by #1714
Labels
bug Something isn't working

Comments

@DaniPopes
Copy link
Collaborator

DaniPopes commented Sep 18, 2022

Rust Analyzer throws errors due to cyclic deps in ethers-derive-eip712 and ethers-middleware/ethers-contract. Already mentioned in #481 (comment), although I don't think the follow-up PR happened ^^

Log:

[ERROR project_model::workspace] cyclic deps: ethers_derive_eip712(CrateId(152)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_derive_eip712(CrateId(152))
[ERROR project_model::workspace] cyclic deps: ethers_middleware(CrateId(155)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_middleware(CrateId(155))
[ERROR project_model::workspace] cyclic deps: ethers_signers(CrateId(165)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_derive_eip712(CrateId(152)) -> ethers_signers(CrateId(165))
[ERROR project_model::workspace] cyclic deps: ethers_signers(CrateId(165)) -> ethers_derive_eip712(CrateId(152)), alternative path: ethers_derive_eip712(CrateId(152)) -> ethers_signers(CrateId(165))
[ERROR project_model::workspace] cyclic deps: ethers_derive_eip712(CrateId(152)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_derive_eip712(CrateId(152))
[ERROR project_model::workspace] cyclic deps: ethers_middleware(CrateId(155)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_middleware(CrateId(155))
[ERROR project_model::workspace] cyclic deps: ethers_signers(CrateId(165)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_derive_eip712(CrateId(152)) -> ethers_signers(CrateId(165))
[ERROR project_model::workspace] cyclic deps: ethers_signers(CrateId(165)) -> ethers_derive_eip712(CrateId(152)), alternative path: ethers_derive_eip712(CrateId(152)) -> ethers_signers(CrateId(165))
@DaniPopes DaniPopes added the bug Something isn't working label Sep 18, 2022
@mattsse mattsse mentioned this issue Sep 18, 2022
3 tasks
@DaniPopes
Copy link
Collaborator Author

#1714 does fix the ethers-derive-eip712, thanks @mattsse, but there's a few more

I'm using the rust-analyzer extension for VS Code and the logs are under the Output > Rust Analyzer Language Server

[ERROR project_model::workspace] cyclic deps: ethers_middleware(CrateId(155)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_middleware(CrateId(155))
[ERROR project_model::workspace] cyclic deps: ethers_signers(CrateId(165)) -> ethers_contract(CrateId(147)), alternative path: ethers_contract(CrateId(147)) -> ethers_middleware(CrateId(155)) -> ethers_signers(CrateId(165))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant