This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: add ProviderExt trait #1559
Merged
+157
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gakonst
approved these changes
Aug 3, 2022
mfornet
reviewed
Aug 24, 2022
| Chain::Oasis => 5_500, | ||
| Chain::Emerald => 6_000, | ||
| Chain::Dev | Chain::AnvilHardhat => 200, | ||
| _ => return None, |
There was a problem hiding this comment.
I think it is better to explicitly catch other variants, otherwise it will be very easy for others contributor that are adding new networks to miss this match!
There was a problem hiding this comment.
sorry I wasn't clear. Still return None is fine, but instead of using _ as a pattern, write down all other enum variants.
This way if a new network is added, compiler will help developer noticing that this is something to fill in.
There was a problem hiding this comment.
reasonable, do you want to add this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
moved from foundry-rs/foundry#2559
Solution
ProviderExttrait forHttpProviderthis is currently sealed to prevent impl outside of ethers until we finalize #1267
PR Checklist