-
Notifications
You must be signed in to change notification settings - Fork 794
Conversation
Ganache is needed for the Ganache tests
this was only possible in ganache because it gives serial sub ids, but in every other reasonable client the ids are generated randomly, so we cannot test for its value
There is a bug in Ganache's mempool which accepts duplicate transactions (here with the same nonce), whereas here we pre-set all the nonces so that they end up having a different transaction hash.
01141f3
to
e1efec5
Compare
I also think we may want to replace all
for the call |
some tests start to fail now
Anvil does not support IPC yet
@mattsse the commit above where I replaced Geth txpool with Anvil highlights some new issue in the mempool implementation I think |
used the current gas price rather than the gas price set by the tx, fixed here foundry-rs/foundry#1756 which should unblock this once included in nightly |
fa0383e
to
f823d62
Compare
50c465f
to
466be46
Compare
466be46
to
5e6af90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's goooo
Motivation
Closes #1227
supersedes #1229
Solution
PR Checklist