This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(solc): Add standard-json-input #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
Apr 8, 2022
ethers-solc/src/lib.rs
Outdated
| @@ -426,6 +426,36 @@ impl<T: ArtifactOutput> Project<T> { | |||
| pub fn flatten(&self, target: &Path) -> Result<String> { | |||
| self.paths.flatten(target) | |||
| } | |||
|
|
|||
| /// Returns standard-json-input to compile the target contract | |||
| pub fn standard_json_input(&self, target: &Path) -> Result<String> { | |||
There was a problem hiding this comment.
I'd rather return a the CompilerInput here instead
There was a problem hiding this comment.
@mattsse I make it return string consistent with flatten. wdyt?
There was a problem hiding this comment.
still, I think CompilerInput would make more sense here and could be useful to for example use it directly with Solc::compile
gakonst
approved these changes
Apr 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This changes will allows
forge verify-contractto submit contract verification usingstandard-input-jsonformat to etherscan.Solution
PR Checklist