This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(solc): add bytecode hash variants #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/add-metadata-variants
branch
from
84fcff9 to
2d4bbd9
Compare
gakonst
reviewed
Apr 4, 2022
ethers-solc/src/artifacts/mod.rs
Outdated
| impl Default for BytecodeHash { | ||
| fn default() -> Self { | ||
| // ipfs general default https://docs.soliditylang.org/en/latest/using-the-compiler.html#compiler-api | ||
| BytecodeHash::Ipfs |
There was a problem hiding this comment.
Let's make it None and document that it's by default None?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add concrete BytecodeHash Variants
Solution
PR Checklist