Implement arrow-parens to support type parameters #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyleunderwood
commented
Jul 18, 2019
| "flowtype/require-return-type": 0, | ||
| "flowtype/require-valid-file-annotation": 0, | ||
| "flowtype/require-readonly-react-props": 0, |
There was a problem hiding this comment.
I think a post-commit hook modified this file?
lyleunderwood
commented
Jul 18, 2019
| // can therefore be safely ignored. | ||
| if (node.typeParameters) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is the relevant bit. My assumption is that if the arrow function has type parameters, then we can safely ignore it because any arrow function with type parameters and no parens is always a parse error.
lyleunderwood
commented
Jul 18, 2019
|
|
||
| Enforces the consistent use of parentheses in arrow functions. | ||
|
|
||
| This rule has a string option and an object one. |
There was a problem hiding this comment.
Grabbed all this stuff from the eslint documentation here.
|
Thank you. LGTM |
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #344.
I did this quick and dirty, and I'm not sure if it's the correct approach. What I did was:
arrow-parensrule and tests intoeslint-plugin-flowtypefromeslint,eslint-plugin-flowtypeenvironment,arrow-parensrule so that the tests passed.Let me know if there's a better way to override an eslint rule. Also, I'm not sure if this should go into the recommended config or whatever.
This may also be of interest to typescript-eslint/typescript-eslint#14.