Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored as ES6 class and High-order Component #4

Closed
cwelch5 opened this issue May 8, 2015 · 4 comments
Closed

Refactored as ES6 class and High-order Component #4

cwelch5 opened this issue May 8, 2015 · 4 comments

Comments

@cwelch5
Copy link

cwelch5 commented May 8, 2015

I refactored react-side-effect as an ES6 class to be used as a high-order component instead of a mixin. Would you be interested in seeing it, I can submit a PR?
@gaearon
Copy link
Owner

gaearon commented May 9, 2015

Sure, please do.

@cwelch5 cwelch5 mentioned this issue May 11, 2015
Closed
@BradEstey
Copy link

👍 +1

@necolas necolas mentioned this issue Jul 4, 2015
Closed
@mikestopcontinues
Copy link

+1

@gaearon
Copy link
Owner

gaearon commented Aug 27, 2015

Done in 1.0.0.

@gaearon gaearon closed this as completed Aug 27, 2015
TrySound referenced this issue in TrySound/react-clientside-effect Jul 31, 2019
@theKashey
Merge pull request theKashey#4 from ezhlobo/radio-group
fd88ab8 
Add tests for better handling of focus on the forms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored as ES6 class to be used as a high-order component. cwelch5/react-side-effect
4 participants
@mikestopcontinues @BradEstey @gaearon @cwelch5