-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.6.0 doesn't work with react-router #43
Comments
It's a very vague description :-). Can you publish a reproducible example? |
This is facebook/react#2517 showing its head again. Instead of: Router.run(routes, Router.HistoryLocation, (Handler) => {
React.render(
<Provider store={store}>
{() => <Handler />}
</Provider>, document.getElementById('root'));
}); write Router.run(routes, Router.HistoryLocation, (Handler, props) => { // note "props" here
React.render(
<Provider store={store}>
{() => <Handler {...props} />} // note "props" here
</Provider>, document.getElementById('root'));
}); We need to document this. I think this shouldn't affect React Router 1.0 but if you could verify this, it would be nice. |
Documented in d4ae7b4. |
thx for the clarification) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm having rather strange issue in my app. After upgrading to 0.6.0 transitions to routes stoped working. While url in browser is changing the page stays the same. With 1.0.0-alpha everything works fine.
The text was updated successfully, but these errors were encountered: