We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should add a try-catch there or be more careful copying descriptors.
The text was updated successfully, but these errors were encountered:
Hey Dan, I wanted to try my hand at this, do you mind adding a little bit more information about how you're getting it to fail?
Sorry, something went wrong.
I think something like this
class Stuff extends Component { render() { return <div /> } } Object.defineProperty(Stuff, { configurable: false, value: 42 })
and try to patch that up with a new version. I think you can tweak static-descriptors test cases to repro this.
static-descriptors
Excuse my ignorance, but shouldn't this issue also cover non-writable properties like prototype.constructor? I am defining the constructor property as read only out of good habit. Hot reloading breaks when it is patched here: https://github.com/gaearon/react-proxy/blob/next/src/createClassProxy.js#L216
prototype.constructor
constructor
No branches or pull requests
We should add a try-catch there or be more careful copying descriptors.
The text was updated successfully, but these errors were encountered: