Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline in the issue message are not escaped when building the json #181

Open
dzamlo opened this issue Oct 2, 2018 · 4 comments
Open

Newline in the issue message are not escaped when building the json #181

dzamlo opened this issue Oct 2, 2018 · 4 comments

Comments

@dzamlo
Copy link

dzamlo commented Oct 2, 2018

If the message of an issue contain a newline (\n) character, it isn't escaped line when the codeclimate.json file is generated. This means that the value for the "check_name" key contains an new line character. This makes the json invalid and Gitlab then fail to parse it.

@gabrie-allaigre
Copy link
Owner

Hi,
Have you example for json file ?
Thanks

@dzamlo
Copy link
Author

dzamlo commented Oct 2, 2018

gl-code-quality-report.json.txt

I replaced potentially sensitive information by --removed--.

The issue come from https://github.com/mwz/sonar-scala

@dzamlo
Copy link
Author

dzamlo commented Oct 6, 2018

According to https://tools.ietf.org/html/rfc4627 and http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf, all character with value < 32 should be escaped, not only the new line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants