Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider improving S3 creds mgmt #36

Open
brainstorm opened this issue Jan 13, 2023 · 0 comments
Open

Consider improving S3 creds mgmt #36

brainstorm opened this issue Jan 13, 2023 · 0 comments

Comments

@brainstorm
Copy link

The following code is present on two different locations of the code:

-       defaultCfg, err := config.LoadDefaultConfig(context.TODO())
+       defaultCfg, err := config.LoadDefaultConfig(
+               context.Background(),
+       )

The additions represent the change needed to support AWS CLI v2 properly (default in 2023?). Otherwise all HeadObject requests will fail with 400.

I'd open a PR, but seems like this project is abandoned by looking at the outstanding issues and PRs from external collaborators?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brainstorm