Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change config.apiOrigin to config.host (or better name)? #97

Open
payne-chris-r opened this issue Apr 8, 2017 · 3 comments
Open

change config.apiOrigin to config.host (or better name)? #97

payne-chris-r opened this issue Apr 8, 2017 · 3 comments

Comments

@payne-chris-r
Copy link
Contributor

It can be confusing that config.apiOrigins exists in the config.js file but the key you use to build out the ajax URL is config.apiOrigin

@gaand
Copy link

gaand commented Apr 8, 2017

No to config.host. That misses the point entirely.

Please think through why I might have chosen these names.

@payne-chris-r
Copy link
Contributor Author

It's assigning ONE of the urls from the apiOrigins object to BE the apiOrigin. I get it, just seems like there may be a better name for it once it's finalized? #namingThingsIsHard

@gaand
Copy link

gaand commented Apr 13, 2017

Too true. But naming things poorly is easy 🤖

host is inspecific. I'm okay with finding a better name than what's used for either key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants