Replies: 1 comment
-
Good question! IIRC, I did that at the beginning is probably because of simplicity of the code generator - the ZeroCopyBuffer is in allo_isolate. I only need to write naive code generator that passes this around. If we are going to change the default behavior, I guess we can contribute to https://github.com/sunshine-protocol/allo-isolate's ZeroCopyBuffer-related things. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
After #1221, I wondered why we would need to copy
Vec<u8>
when we have the ability to 'zero copy' the bytes array. What if we could just zero copyVec<u8>
types by default without explicitZeroCopyBuffer
? If I can contribute, would it be okay to work on this idea and deprecateZeroCopyBuffer
?If this is accepted, proper documentation and depreciation warning should be added.
I know that the idea of 'binding unmodified rust' is ongoing, but maybe this change could be applied prior to that.
Beta Was this translation helpful? Give feedback.
All reactions