-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with fyne release does not set Metadata().Release to true #4711
Comments
What is the release of the fyne command line? ( |
I thought I could replicate this but I cannot. The |
The output of fyne --version is "fyne version v2.4.4" I tried to run the above code with
For each the string printed to terminal was test |
Maybe this is for some reason a platform specific bug, are you trying to check this only on MacOS? Or also tried it on Windows and Linux? I do not have a windows install with the dev enviornment setup right now, I could check it another day on Windows if it could help track down the core of this issue |
The last "the built binary" is concerning me - did you clear out the previous one before testing release? What was the path to the release binary that you tested? |
I deleted the binary that built with fyne build first. Then I ran fyne release which created an archive which I extracted and ran that extracted binary |
Can you please compile the tool locally with a log of "b.release" on line 199 of cmd/fyne/internal/commands/build.go (inside build() function). That way we can see if false is being passed in somehow. If so then a "debug.PrintStack" would help a lot. |
Just so I understand you correctly, you would like for me to compile fyne v2.4.4 locally with the changes you requested above? |
Locally compiled source code (go install .) for fyne v2.4.4 with the addition of "log.Println(b.release)". Tried to do the same with "fyne package - os linux --release". Log during compile was true but after running the executed binary the metadata was true this time. Doing the same with "fyne package - os linux" goes to false on both compile log and print of executed binary. |
Thanks this has been very helpful, PR inbound |
Fixes fyne-io#4711 which was somehow Linux specific
Resolved for v2.4.5 and 2.5 on develop |
Checklist
Describe the bug
Building with fyne release does not set Metadata().Release to true.
Also affects building with fyne-cross
How to reproduce
Build the code in example with fyne release or fyne-cross and it prints out test to the terminal where it should print out prod.
Screenshots
No response
Example code
The text was updated successfully, but these errors were encountered: