Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement theme variant auto-switching (dark/light) for Windows #4537

Closed
2 tasks done
dweymouth opened this issue Jan 12, 2024 · 1 comment
Closed
2 tasks done

Implement theme variant auto-switching (dark/light) for Windows #4537

dweymouth opened this issue Jan 12, 2024 · 1 comment
Labels
OS:Windows Tickets affecting only Microsoft Windows

Comments

@dweymouth
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

There is currently no implementation of detecting the dark/light preference changing on Windows. This was previously only tracked with a TODO in the code here

Is it possible to construct a solution with the existing API?

No response

Describe the solution you'd like to see.

An implementation for Windows, possibly based on this MIT-licensed Gist

@dweymouth dweymouth added the OS:Windows Tickets affecting only Microsoft Windows label Jan 12, 2024
@dweymouth
Copy link
Contributor Author

Fixed on release branch for 2.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS:Windows Tickets affecting only Microsoft Windows
Projects
None yet
Development

No branches or pull requests

2 participants