Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong background for color dialog #4199

Closed
2 tasks done
Jacalz opened this issue Aug 26, 2023 · 0 comments
Closed
2 tasks done

Wrong background for color dialog #4199

Jacalz opened this issue Aug 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Jacalz
Copy link
Member

Jacalz commented Aug 26, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

The advanced color dialog picker wheel has a dark rectangular background because it still uses the old background color and not theme.OverlayBackgroundColor() outside of the circle.

How to reproduce

  1. Open the dialogs panel in fyne_demo.
  2. Open the advanced color picker and open up the advanced accordion.
  3. Notice the black rectangle around the color wheel.

Screenshots

image

Example code

See fyne_demo.

Fyne version

8b4fd1e

Go compiler version

Go 1.20.7

Operating system and version

Fedora Linux 38

Additional Information

I opened #4198 but there is some weird behaviour of the test images. In general, the all of the code for the color dialog probably needs a make over. The code has not really been touched in years since the original developer left the project. The code is complicated and doesn't follow our code standards of today. It is just silently rotting away...

@Jacalz Jacalz added the bug Something isn't working label Aug 26, 2023
@Jacalz Jacalz added this to the D fixes (v2.4.x) milestone Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants