Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyne package should optionally pad icons for Mac OS to fit conventions #3752

Closed
2 tasks done
dweymouth opened this issue Mar 21, 2023 · 3 comments
Closed
2 tasks done
Labels
enhancement New feature or request

Comments

@dweymouth
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

On Mac OS, application icons are supposed to have a small amount of transparent padding around the main icon image (this is to allow for icons that have a "tool" like the hammer in the XCode icon that extend beyond the main image's rounded rectangle). See here and here for more info.

Is it possible to construct a solution with the existing API?

No response

Describe the solution you'd like to see.

It would be nice for fyne package to be able to automatically add the standard amount of padding around the input icon when packaging for Mac OS. This should be optional/disableable in case the developer has already prepared an icon asset that is directly suitable for Mac OS.

@andydotxyz
Copy link
Member

Should we add the curved corner as well? This happens automatically on iOS apps...

@andydotxyz andydotxyz added the enhancement New feature or request label Mar 26, 2023
@andydotxyz andydotxyz added this to the Dalwhinnie (May/June 2023) milestone Mar 26, 2023
@dweymouth
Copy link
Contributor Author

Should we add the curved corner as well? This happens automatically on iOS apps...

Yes that would be nice too. Of course it should be disableable/optional as well. I manually rounded corners for my icon (and it's rounded on Linux/Windows too) but I had to prepare a mac-specific padded version.

@andydotxyz
Copy link
Member

Fixed on develop :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants