Clone Settings - Add Core APIs #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin1111
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ashwin1111
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ashwin1111
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ashwin1111
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Shwetabhk
reviewed
Apr 18, 2023
apps/users/urls.py
Outdated
| path('orgs/', FyleOrgsView.as_view()) | ||
| path('orgs/', FyleOrgsView.as_view()), | ||
| path( | ||
| 'clone_settings/availability/', |
There was a problem hiding this comment.
Suggested change
| 'clone_settings/availability/', | |
| 'clone_settings/exists/', |
Shwetabhk
reviewed
Apr 18, 2023
| from apps.workspaces.models import Workspace, WorkspaceGeneralSettings | ||
|
|
||
| User = get_user_model() | ||
|
|
Shwetabhk
reviewed
Apr 18, 2023
| if workspace_general_setting: | ||
| return workspace_general_setting.workspace | ||
|
|
||
| return None |
There was a problem hiding this comment.
we don't need to explicitly return None
Shwetabhk
reviewed
Apr 18, 2023
|
|
||
| from django.db import transaction | ||
|
|
||
| from apps.workspaces.apis.export_settings.serializers import ExportSettingsSerializer, \ |
There was a problem hiding this comment.
instead of using \ you can enclose imports in paranthesis, it is cleaner that way
from apps.workspaces.apis.export_settings.serializers import (
ExportSettingsSerializer,
...
)
Shwetabhk
reviewed
Apr 18, 2023
|
|
||
|
|
||
| class CloneSettingsSerializer(serializers.ModelSerializer): | ||
| export_settings = ReadWriteSerializerMethodField() |
There was a problem hiding this comment.
Check if we can do something like this and that way we'll not need to explicitly add validations, not sure if we can do this, but it will be much cleaner that way
Suggested change
| export_settings = ReadWriteSerializerMethodField() | |
| export_settings = ReadWriteSerializerMethodField(null=False, blank=False) |
There was a problem hiding this comment.
this doesn't seem to be possible, have checked it out
Shwetabhk
reviewed
Apr 18, 2023
| instance, data=advanced_settings, partial=True | ||
| ) | ||
|
|
||
| if export_settings_serializer.is_valid(raise_exception=True) and \ |
There was a problem hiding this comment.
I think it will only come to the update function if the serializer are valid, do we need to to this?
There was a problem hiding this comment.
validations aren't raising exception if we don't send this
Shwetabhk
reviewed
Apr 18, 2023
| latest_workspace = get_latest_workspace(self.request.user) | ||
|
|
||
| return Workspace.objects.filter(id=latest_workspace.id).first() | ||
|
|
Shwetabhk
reviewed
Apr 18, 2023
|
|
||
| return Workspace.objects.filter(id=latest_workspace.id).first() | ||
|
|
||
| class CloneSettingsAvailabilityView(generics.RetrieveAPIView): |
There was a problem hiding this comment.
Suggested change
| class CloneSettingsAvailabilityView(generics.RetrieveAPIView): | |
| class CloneSettingsExistsView(generics.RetrieveAPIView): |
Shwetabhk
requested changes
Apr 18, 2023
apps/users/urls.py
Outdated
| @@ -2,7 +2,14 @@ | |||
|
|
|||
| from .views import UserProfileView, FyleOrgsView | |||
|
|
|||
| from apps.workspaces.apis.clone_settings.views \ | |||
| import CloneSettingsAvailabilityView | |||
There was a problem hiding this comment.
Suggested change
| import CloneSettingsAvailabilityView | |
| import CloneSettingsExistsView |
Shwetabhk
approved these changes
Apr 18, 2023
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 97.03% 97.11% +0.08%
==========================================
Files 44 47 +3
Lines 3436 3505 +69
==========================================
+ Hits 3334 3404 +70
+ Misses 102 101 -1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
anishfyle
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Prefill API - POC * Get latest updated workspace * Prefill availability * Rename and refactor APIs * Add unit tests * Fix PR comments * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.