Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable composer-asset-plugin from root composer.json #249

Closed
nkovacs opened this issue Aug 24, 2016 · 10 comments
Closed
Assignees
Milestone

Comments

@nkovacs
Copy link

nkovacs commented Aug 24, 2016

I'd like to use asset-packagist, but I have to have composer-asset-plugin installed globally for other projects, and having it installed negates almost all of the speed benefits of asset-packagist. I can't use composer's --no-plugins option either.

I'd like to disable composer-asset-plugin from the project's composer.json (since that's where I have to add asset-packagist as a repository) so that I can work on both kinds of projects.

@schmunk42
Copy link
Contributor

@nkovacs Can you work around that with COMPOSER_HOME https://getcomposer.org/doc/03-cli.md#composer-home?

@nkovacs
Copy link
Author

nkovacs commented Aug 26, 2016

Not really. I'm not in control of the environment of the developers working on the project, I can only change the project's composer.json.

@francoispluchino
Copy link
Member

In this case, we cannot disable the plugin if env variable and Composer extra option are not possible.

@nkovacs
Copy link
Author

nkovacs commented Aug 26, 2016

Can't you make it not do anything?

@francoispluchino
Copy link
Member

We can disable the plugin with a environment variable or an extra option in the project composer.json file.

@nkovacs
Copy link
Author

nkovacs commented Aug 26, 2016

or an extra option in the project composer.json file.

That's exactly what I'd like (I misunderstood your comment).

@francoispluchino
Copy link
Member

ok, with your previous comment, I thought that possibility was not possible.

@francoispluchino francoispluchino self-assigned this Feb 16, 2017
@francoispluchino francoispluchino added this to the 1.3.0 milestone Feb 16, 2017
@francoispluchino
Copy link
Member

My approach for this new feature:

  1. Use the global config option config.fxp-asset.enabled with the default value true
  2. Override the config option with the custom option defines in the project composer file file (always with config.fxp-asset.enabled
  3. Enable or disable the plugin

@schmunk42
Copy link
Contributor

@francoispluchino What's about #251 - I think it would be great if we could just disable the requests, if cache has been filled in the past x days - regarding performance.

@francoispluchino
Copy link
Member

Added by fda53b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants