Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keyboard shortcut discoverable / changeable #80

Open
electriquo opened this issue Nov 27, 2017 · 3 comments
Open

Make keyboard shortcut discoverable / changeable #80

electriquo opened this issue Nov 27, 2017 · 3 comments
Labels
Feature Things the extension should do but isn't yet.

Comments

@electriquo
Copy link

thank you for making it compatible with quantum!
i rate it 3 stars since it is missing the ability to assign a a keyboard shortcut rather than looking for buttons and get the hands off from the keyboard and onto the mouse.

i used to work with shortly url shortner, but it incompatible with quantum.
it used to let you choose the url shortner service (bit.ly, goo.gl, etc.) and once you assign a keyboard shortcut, when using the shortcut it automatically shorten the url and copies it to the clipboard.

if you had such functionality, it will be a bliss.

@fwenzel
Copy link
Owner

fwenzel commented Nov 30, 2017

There is a keyboard shortcut already: Ctrl + Shift + L, as defined here: https://github.com/fwenzel/copy-shorturl/blob/master/src/manifest.json#L34

I can look into how that can be changed, but the feature exists.

@electriquo
Copy link
Author

@fwenzel the keyboard shortcut it not documented anywhere (amo, github and the addon information within firefox itself). i think it should be added for clarity and transparency.
the shortcut is much more productive, no need to seek for the mouse.

if you implement a way to bind differently keys, it will extra fine.
thank you for all the fine work!

@fwenzel fwenzel changed the title feature request: keyboard shortcut Make keyboard shortcut discoverable / changeable Jan 14, 2018
@fwenzel
Copy link
Owner

fwenzel commented Feb 11, 2020

It turns out we can change this programmatically! https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/commands/update

@fwenzel fwenzel added the Feature Things the extension should do but isn't yet. label Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Things the extension should do but isn't yet.
Projects
None yet
Development

No branches or pull requests

2 participants