diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java index 3f9f4108d82570..db26245aa69ad8 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java @@ -885,14 +885,10 @@ public List getArguments() throws CommandLineExpansionException { @Override public Sequence getStarlarkArgv() throws EvalException, InterruptedException { try { - if (cppConfiguration.ignoreParamFile()) { - return StarlarkList.immutableCopyOf( - compileCommandLine.getArguments( - /*parameterFilePath=*/ null, getOverwrittenVariables())); + return StarlarkList.immutableCopyOf( + compileCommandLine.getArguments( + /* parameterFilePath= */ null, getOverwrittenVariables())); - } else { - return StarlarkList.immutableCopyOf(getArguments()); - } } catch (CommandLineExpansionException ex) { throw new EvalException(ex); } diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java index 363f17a4c111ab..9be42251e01ca3 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java @@ -367,10 +367,6 @@ public boolean isCSFdo() { return cppOptions.isCSFdo(); } - public boolean ignoreParamFile() { - return cppOptions.ignoreParamFile; - } - public boolean useArgsParamsFile() { return cppOptions.useArgsParamsFile; } diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java index 57154edd06743f..f42eaaf294a4a9 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java @@ -1062,13 +1062,11 @@ public Label getPropellerOptimizeLabel() { name = "experimental_cpp_compile_argv_ignore_param_file", defaultValue = "true", documentationCategory = OptionDocumentationCategory.UNDOCUMENTED, - effectTags = {OptionEffectTag.BAZEL_INTERNAL_CONFIGURATION}, + effectTags = {OptionEffectTag.NO_OP}, metadataTags = { OptionMetadataTag.EXPERIMENTAL, }, - help = - "If enabled, CppCompileAction action.argv returns the complete list of argv even if" - + " compiler_param_file is enabled.") + help = "This flag is a noop and scheduled for removal.") public boolean ignoreParamFile; @Option( diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java index 3aae3acc2311ca..d4bd9afe1a6f87 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java @@ -1147,24 +1147,6 @@ public void testCompilationParameterFile() throws Exception { .containsExactly("/usr/bin/mock-gcc", "@/k8-fastbuild/bin/a/_objs/foo/foo.o.params"); } - @Test - public void testCppCompileActionArgvReturnParamFile() throws Exception { - AnalysisMock.get() - .ccSupport() - .setupCcToolchainConfig( - mockToolsConfig, - CcToolchainConfig.builder().withFeatures(CppRuleClasses.COMPILER_PARAM_FILE)); - useConfiguration("--noexperimental_cpp_compile_argv_ignore_param_file"); - scratch.file("a/BUILD", "cc_library(name='foo', srcs=['foo.cc'])"); - CppCompileAction cppCompileAction = getCppCompileAction("//a:foo"); - ImmutableList argv = - cppCompileAction.getStarlarkArgv().stream() - .map(x -> removeOutDirectory(x)) - .collect(ImmutableList.toImmutableList()); - assertThat(argv) - .containsExactly("/usr/bin/mock-gcc", "@/k8-fastbuild/bin/a/_objs/foo/foo.o.params"); - } - @Test public void testCppCompileActionArgvIgnoreParamFile() throws Exception { AnalysisMock.get()