Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better mechanism for recreating pods on Helm upgrade #128

Open
fwcd opened this issue Jan 28, 2023 · 0 comments
Open

Add better mechanism for recreating pods on Helm upgrade #128

fwcd opened this issue Jan 28, 2023 · 0 comments
Labels
ci-cd CI/CD-related (GitHub Actions, GitLab CI, ...) docker Docker-related

Comments

@fwcd
Copy link
Owner

fwcd commented Jan 28, 2023

We currently use a timestamp annotation in our deployment template (similar to the suggestion in https://stackoverflow.com/a/64151965) to ensure that the helm upgrade run by GitHub Actions always recreates the pods. However, terminating a D2 pod sometimes takes up to a minute, during which both the old and the new instance may respond to user commands.

Ideally, we could find a way to either wait for the old pod to fully terminate (with the downside of having ~1m downtime per deployment), coordinate termination in a way that the terminating pod no longer responds (perhaps even by using Discord's sharding mechanism?) or restart the pod directly after running helm upgrade.

@fwcd fwcd added ci-cd CI/CD-related (GitHub Actions, GitLab CI, ...) docker Docker-related labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI/CD-related (GitHub Actions, GitLab CI, ...) docker Docker-related
Projects
None yet
Development

No branches or pull requests

1 participant