Fixes Outer Stream in concurrent.join to fail join #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #868 |
|
👍 We can release 0.9.6 (I plan for 0.9 to have fixes published for a long time due to some of the API changes in 1.0). Before doing so, I'd like to get #865 addressed too, but I've been very busy on 1.0 work. |
|
@pchlupacek Don't worry about 1.0 -- I just merged this there and I'm about to merge it to topic/fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mpilquist I think this is not that critical fix, but perhaps we shall make 0.9.6? Not sure if anything else is on table for 0.9 branch
Shall I create another PR for 1.0.0 series?