Skip to content

Step 7: Remove scaffold agent fallback infrastructure #5552

Description

@ggallen

Context

Step 7 of the agent extraction plan removes scaffold-based agent resolution infrastructure now that all six first-party agents are extracted to fullsend-ai/agents and registered in org config (Steps 1–6 complete).

Tracking

Completed (PR #5425)

  • Remove MergedAgents, LookupMergedAgent, HarnessWrappersLayer, AgentEntryBuilder, DefaultAgentEntries, configAgentNames
  • Remove disk-based harness fallback from resolveAgentSource
  • Simplify to 2-tier model: config → agents-repo fallback
  • Update plan docs and ADRs with removal annotations

Remaining (follow-up PRs)

  • Item 1: Delete scaffold harness YAML files (internal/scaffold/fullsend-repo/harness/)
  • Item 5: Remove HarnessNames() / HarnessBaseURLWithHash() after migrate.go no longer needs them
  • Item 6: Update fullsend lock to be config/agents-repo-aware (currently disk-only via resolveHarnessPath)
  • Item 7: Delete remaining scaffold agent files (agents/, env/, policies/, schemas/, scripts/, skills/)
  • Item 8: Update Makefile and test infrastructure

Prerequisites verified

All installations have config-driven agent entries. The agents-repo fallback covers the 6 known first-party agents for online environments. See PR #5425 description for full migration prerequisite verification.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedBlocked by another issue or external dependencycomponent/harnessAgent harness, config, and skills loadingtech-debt

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions