From e03dc6184c28c0abf033fca18228cf8422eed6f3 Mon Sep 17 00:00:00 2001
From: fullsend-code <fullsend-code@users.noreply.github.com>
Date: Mon, 25 May 2026 11:03:19 +0000
Subject: [PATCH] fix(#1408): deduplicate retro dispatches on PR merge
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When a PR is merged, multiple queued shim runs (each using
cancel-in-progress: false) independently process the closed
event and dispatch a retro workflow. While retro.yml already
has a concurrency group with cancel-in-progress: true, retro
runs may complete before the next dispatch arrives, making
cancellation ineffective and producing 2-6 duplicate retro
runs per merge.

Add a dedup check in the dispatch step: before dispatching a
retro workflow, query the GitHub API for queued or in-progress
retro runs with matching source repo and PR number. If a match
is found, skip the dispatch with a notice annotation. The
check is fail-open — API errors fall through to normal
dispatch to avoid blocking legitimate retro runs.

Note: Go tests could not run (sandbox has Go 1.23, project
requires 1.26). The change is workflow YAML only and does not
affect Go source. Pre-commit could not complete (Go toolchain
download blocked in sandbox). Manual verification required.

Closes #1408
---
 .../.github/workflows/dispatch.yml            | 25 ++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/internal/scaffold/fullsend-repo/.github/workflows/dispatch.yml b/internal/scaffold/fullsend-repo/.github/workflows/dispatch.yml
index a2c7164cc4..f47dfd4e2d 100644
--- a/internal/scaffold/fullsend-repo/.github/workflows/dispatch.yml
+++ b/internal/scaffold/fullsend-repo/.github/workflows/dispatch.yml
@@ -1,4 +1,4 @@
-# lint-workflow-size: max-lines=390
+# lint-workflow-size: max-lines=415
 # Dispatcher workflow that routes events to agent workflows based on stage.
 # Routing logic determines the stage from event context — the shim only
 # forwards the raw event.  Adding a new stage requires only a case branch
@@ -324,6 +324,29 @@ jobs:
             comment: (.comment // null | if . then {body: .body[:4096]} else null end)
           }' "$GITHUB_EVENT_PATH")
 
+          # Deduplicate retro dispatches — if a retro workflow run is
+          # already queued or in-progress for the same source repo + PR,
+          # skip this dispatch.  Multiple shim runs for the same PR close
+          # event each call dispatch independently; this check prevents
+          # all but the first from launching a redundant retro run.
+          if [[ "$STAGE" == "retro" ]]; then
+            RETRO_PR=$(echo "$EVENT_PAYLOAD" | jq -r '(.pull_request.number // .issue.number) | tostring')
+            if [[ -n "$RETRO_PR" && "$RETRO_PR" != "null" ]]; then
+              ACTIVE_IDS=$(gh api "repos/${DISPATCH_REPO}/actions/workflows/retro.yml/runs?per_page=10" \
+                --jq '[.workflow_runs[] | select(.status == "queued" or .status == "in_progress") | .id] | .[]' 2>/dev/null || true)
+              for rid in $ACTIVE_IDS; do
+                RUN_INPUTS=$(gh api "repos/${DISPATCH_REPO}/actions/runs/${rid}" --jq '.inputs' 2>/dev/null || echo '{}')
+                RUN_SRC=$(echo "$RUN_INPUTS" | jq -r '.source_repo // empty')
+                RUN_PR=$(echo "$RUN_INPUTS" | jq -r '.event_payload' 2>/dev/null \
+                  | jq -r '(.pull_request.number // .issue.number) | tostring' 2>/dev/null || true)
+                if [[ "$RUN_SRC" == "$SOURCE_REPO" && "$RUN_PR" == "$RETRO_PR" ]]; then
+                  echo "::notice::Retro already active for ${SOURCE_REPO}#${RETRO_PR} (run ${rid}) — skipping duplicate dispatch"
+                  exit 0
+                fi
+              done
+            fi
+          fi
+
           echo "Scanning for workflows with stage: $STAGE"
 
           dispatched=0