Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SV calling on Consensus BAMs #594

Closed
kanika-arora opened this issue Jun 25, 2020 · 6 comments
Closed

SV calling on Consensus BAMs #594

kanika-arora opened this issue Jun 25, 2020 · 6 comments

Comments

@kanika-arora
Copy link

I am testing fgbio for collapsing duplex reads. I run GroupReadsByUmi with paired strategy, followed by CallDuplexConsensusReads and FilterConsensusReads to get duplex BAM files. We are interested in calling SVs from duplex BAMs. I wanted to know if that is feasible.

Could you please elaborate on how fgbio deals with split reads and discordant read-pairs? I saw an older issue, where it says that fgbio filters out reads that map cross-chromosomally. Is that still the case?
How does it deal with read-pairs with one read unmapped, and soft-clipped bases of reads?

Thank you!
Kanika

@tfenne
Copy link
Member

tfenne commented Jun 29, 2020

Hi @kanika-arora - as it stands GroupReadsByUmi does still filter out both a) cross-chromosomal reads pairs and b) read-pairs where one or both ends are unmapped. We made these decisions a long time ago when first working on this and chose to be conservative. I see no reason that one or both restrictions couldn't be relaxed but it would take some work.

Soft-clipped bases generally don't affect the grouping (or consensus) step.

@kanika-arora
Copy link
Author

Thank you for the clarification @tfenne. I think it will be great to be able to call SVs from the consensus BAMs. If there is a future version that will enable that, we'd be very interested in it.
Thank you for help!

@10-m
Copy link

10-m commented Jul 1, 2020

I have deleted the following code to detect SV. That worked well for me.
How does @tfenne think about? Is there any problem what you think?

GroupReadsByUmi.scala:
require(rec.refIndex == rec.mateRefIndex, ....) x 2 places
.filter(r => (r.unpaired || r.refIndex == r.mateRefIndex)

Thanks.

@nh13
Copy link
Member

nh13 commented Aug 13, 2020

@10-m I think that should work fine, but it is unsupported, so a PR is welcome.

@tyyiyi
Copy link

tyyiyi commented Aug 14, 2020

So at present I cannot use GroupReadsByUmi if I want to detect structural variation. So I can just ExtractUmisFromBAM, and do BWA comparisons and mergers, right? It is sincerely expected that structural variations can be detected from consensus BAMs!

Thank you very much!
Tang

@nh13
Copy link
Member

nh13 commented Mar 1, 2021

This should be supported now: #648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants