Reimplement fs.info() to not depend on fs.ls() #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the container's info cannot be obtained from cache, info() now calls get_container_properties() to return all the info available. Fixes fsspec#377.
_info() now only queries the properties of its argument, instead of potentially doing a full listing of the parent directory. Note: due to apparent inconsistencies in Azure, info["deleted"] may now be either False or None for the same path, depending on whether the info dict comes from .info() or .ls(..., detail=True). Also fixes .exists() mishandling paths like "non-existent-container/key". Fixes fsspec#380.
Collaborator
|
This is nice @rlamy . Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.info()now only queries the properties of its argument, instead of potentially doing a full listing of the parent directory, which should improve its performance in many cases.Fixes #377 and #380.
Note: this PR contains refactorings of related methods that I ended up not modifying otherwise, I could split them off if that makes reviewing easier.