-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fable integration #59
Comments
I had a quick look at the code, if you don't depend on reflection it should work (there's indeed some reflection support in Fable but it's limited). SRTP should work and has been improved in Fable 2, if you find an edge case we can try to fix it in Fable. Though it's the fist time I see the If you're using Expecto for the tests I recommend just using some Mocha polyfills as Fable itself does, try to run them with Fable and see what fails. BTW, there's already a similar JSON library for Fable, Thoth.Json. cc @MangelMaxime |
At the moment there is zero reflection code in this library. The generalizable attribute in that example is a bit exotic, the same effect could be achieved by making it a function accepting We're not using Expecto here, we use Fuchu, which is actually the original project Expecto was based on. So probably we can run those tests with Fuchu as well. I had a look a Thoth.Json, it seems to be a minimalistic combinator based library which could be seen as a subset of Fleece if you compare them. On one side, having a simple library could be convenient. The idea of adding more features to Fleece is that it could integrate better with different libraries, being suitable for different scenarios. Maybe we can join efforts at some point. |
I feel like I'm able to work in a flavor compatible with Fable. |
This library uses Fuchu for tests. We could adjust Fuchu to run on both Fable and .net. |
In theory, this library could be perfectly used in the Fable ecosystem.
Although it allows heavy use of SRTP, it also permits to manually specify a codec combinator, the same way ELM inspired Json libs do.
On top of that, the feature of specifying a single codec would also work without relying on SRTP overload, by specifying a codec for each field.
The last sample code in the readme https://github.com/mausch/Fleece#combinators illustrate this.
There shouldn't be any issue to use this in Fable.
I'm not sure what is required in order to by Fable ready, all I know is that there are no stoppers.
Is there anyone interested in take it there?
CC: @alfonsogarciacaro @wallymathieu
The text was updated successfully, but these errors were encountered: