Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new gitlab collapsible logger is still not quite right #2482

Closed
baronfel opened this issue Mar 6, 2020 · 2 comments
Closed

new gitlab collapsible logger is still not quite right #2482

baronfel opened this issue Mar 6, 2020 · 2 comments

Comments

@baronfel
Copy link
Contributor

baronfel commented Mar 6, 2020

Description

We get the following output with the brand-new alpha you just put out:

section_end:1583530107:get_sources
�[0Ksection_start:1583530107:restore_cache
�[0Ksection_end:1583530109:restore_cache
�[0Ksection_start:1583530109:download_artifacts
�[0Ksection_end:1583530110:download_artifacts
�[0Ksection_start:1583530110:build_script
�[0K�[0K

Which doesn't at all look like their raw sample:

section_start:1560896352:my_first_section\r\e[0KHeader of the 1st collapsible section
this line should be hidden when collapsed
section_end:1560896353:my_first_section\r\e[0K
@matthid
Copy link
Member

matthid commented Mar 6, 2020

So what do we do now? Should I revert those changes?

@baronfel
Copy link
Contributor Author

baronfel commented Mar 6, 2020

Possibly. I'm working on another set of changes (and adding tests!) but if I can't get it soon I'd say revert and we can try again next release.

@matthid matthid closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants