Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attributes on let bindings in nested functions. #1214

Closed
4 of 5 tasks
teo-tsirpanis opened this issue Nov 28, 2022 · 4 comments
Closed
4 of 5 tasks

Allow attributes on let bindings in nested functions. #1214

teo-tsirpanis opened this issue Nov 28, 2022 · 4 comments

Comments

@teo-tsirpanis
Copy link

I propose we allow attributes on let bindings in nested functions.

The existing way of approaching this problem in F# is by moving the function outside. An example of attribute one would need to add is trimming annotations

Pros and Cons

The advantages of making this adjustment to F# are simpler and more encapsulated code.

The disadvantages of making this adjustment to F# are 🤷🏻‍♂️

Extra information

Estimated cost (XS, S, M, L, XL, XXL): S

Related suggestions: Not found

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

@abelbraaksma
Copy link
Member

abelbraaksma commented Nov 28, 2022

Related: #984

These two suggestions should probably be considered as one (they’re not the same, but I guess the work to be done is very similar: that is, on compiler generated methods).

@charlesroddie
Copy link

trimming annotations

These are not needed unless you are working outside of type systems, e.g. reflection. F# should make it less convenient to do that (e.g. via warnings that must be disabled), not more!

@Happypig375
Copy link
Contributor

-> #848

@teo-tsirpanis
Copy link
Author

Thanks @Happypig375, closing as duplicate.

@teo-tsirpanis teo-tsirpanis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants