Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add version tags to docker container #179

Open
wuast94 opened this issue Dec 14, 2024 · 4 comments
Open

[FR] Add version tags to docker container #179

wuast94 opened this issue Dec 14, 2024 · 4 comments
Assignees

Comments

@wuast94
Copy link

wuast94 commented Dec 14, 2024

Would be nice to have tagged containers, i see u already use semver versioniong with releases.

i use a git repo with renovate to manage all my services and that way it would nicly integrate there. also in a docker swarm cluster just having a latest tag is always pain.

@wuast94
Copy link
Author

wuast94 commented Dec 14, 2024

also i didnt see the Dockerfile used to build the container, would be nice to add LABEL org.opencontainers.image.source="https://github.com/fscorrupt/Posterizarr" after the last from statement, for reference:

To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification.

For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md

@fscorrupt
Copy link
Owner

Hey, I don’t use versioning in my Docker image because I designed it in a way that doesn’t require updates. It’s just a simple container with the necessary programs installed for Posterizarr. Posterizarr itself has versioning, but it isn’t integrated into the container; it gets pulled when the container starts. This approach allows me to update the script without rebuilding the container. The only things that require updates are PowerShell and ImageMagick, which are visible in the container. I have a check for them, and if updates are available, I trigger a container build.

@wuast94
Copy link
Author

wuast94 commented Dec 14, 2024

so for this you would need to change the script to pin to a specific version the container has or need to do otherwise structual changes, i understand.
at the moment i run Posterizarr and kometa in a extra VM whith much glue to automate updates etc, something i try to get ride of. So the versioning thing is essential for this. On the other hand i switching to jellyfin and there are many things not available atm (Kometa, Tautulli integration etc) so feel free to close this or leave it open if its something you would like to implement at some time in futue

as always, thanks for the great work and response :)

@fscorrupt
Copy link
Owner

Implementing versioning in the container would require structural changes, which doesn’t align with my current approach of Posterizarr handling its own versioning at startup. I’ll keep this in mind for future updates, but I have no plans to change it for now. Feel free to leave this open or close it based on your needs.

Thanks for your feedback - I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants